Skip to content

Use algorithms for poles and zeros of rational matrices from MatrixPencils.jl #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Use algorithms for poles and zeros of rational matrices from MatrixPencils.jl #990

merged 1 commit into from
May 7, 2025

Conversation

baggepinnen
Copy link
Member

Add keyword arguments that are forwarded to MatrixPencils.rmpoles and MatrixPencils.rmzeros. This makes the poles and tzeros functions understand cancellations, it also makes the computations a bit faster

julia> G = tf(ssrand(2,2,6));

julia> using BenchmarkTools

julia> @btime poles(G); # New implementation
  99.067 μs (1288 allocations: 1.46 MiB)

julia> @btime poles(zpk(G)); # Old implementation
  167.226 μs (1372 allocations: 166.44 KiB)

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 1/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.008 Reference New

@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (664eab8) to head (b69edeb).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
+ Coverage   92.43%   92.44%   +0.01%     
==========================================
  Files          41       41              
  Lines        4999     5006       +7     
==========================================
+ Hits         4621     4628       +7     
  Misses        378      378

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@baggepinnen baggepinnen merged commit 6e64c52 into master May 7, 2025
6 checks passed
@baggepinnen baggepinnen deleted the tf_pz branch May 7, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baggepinnen @JuliaControlBot